chore: adds conditional persistence propagation #114
+662
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/TestData.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/TestData.java
Show resolved
Hide resolved
kinyoklion
requested changes
Jan 27, 2026
lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/subsystems/DataStoreTypes.java
Show resolved
Hide resolved
kinyoklion
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
SDK-1622
Describe the solution you've provided
Adds shouldPersist to change set classes.
Note
Medium Risk
Touches core data ingestion and persistence paths (polling/streaming, write-through, recovery) and changes
DataStoreTypesvalue semantics; risk is mainly incorrect persistence gating or missed persistence in edge cases, but changes are straightforward and well-tested.Overview
Adds a
shouldPersistflag toDataStoreTypes.FullDataSetandDataStoreTypes.ChangeSetand threads it through sorting, translation, and store update flows.Polling/streaming/FDv2 changesets are now explicitly marked
shouldPersist=true, while file-based data is markedfalse;WriteThroughStoreandPersistentDataStoreWrapperuse this to skip writes to persistent stores (including during recovery) when data is non-authoritative.InMemoryDataStoretracks and re-exports the latestshouldPersistvalue so downstream persistence decisions are consistent, and tests are updated/expanded accordingly.Written by Cursor Bugbot for commit 35a1038. This will update automatically on new commits. Configure here.